Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve select for Add Navigation Menu Item > Parent #26550

Conversation

larssandergreen
Copy link
Contributor

Before

  1. Hard to use select for Parent because items break onto two lines due to narrow width.
image
  1. Ordering of menu items in select does not respect weight if changed, i.e. if you have re-ordered the menu items, you still get the original order based on id here.

  2. Same select in Reports is not select2.

After

  1. Wider, more usable. Also made Separator a select2.
image
  1. Ordering of menu items respects weight, i.e. it is the same as the actual menu.

  2. Select2 in Reports.

Comments

CiviHR has a copy of CRM/Core/BAO/Navigation.php, so this is a courtesy page for @olayiwola-compucorp (I hope you're the right person).

@civibot
Copy link

civibot bot commented Jun 16, 2023

(Standard links)

@civibot civibot bot added the master label Jun 16, 2023
@demeritcowboy demeritcowboy merged commit 6d325e7 into civicrm:master Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants