Improve select for Add Navigation Menu Item > Parent #26550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Ordering of menu items in select does not respect weight if changed, i.e. if you have re-ordered the menu items, you still get the original order based on id here.
Same select in Reports is not select2.
After
Ordering of menu items respects weight, i.e. it is the same as the actual menu.
Select2 in Reports.
Comments
CiviHR has a copy of
CRM/Core/BAO/Navigation.php
, so this is a courtesy page for @olayiwola-compucorp (I hope you're the right person).