Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing </table> tag on repeat event change confirm tpl. #26547

Merged

Conversation

artfulrobot
Copy link
Contributor

Overview

When changing the repeat end for events, a missing end-table HTML tag causes the heading that introduces a 2nd table to appear above the first table; thus muddling the communication.

Before

⚠️ There are participants registered for repeating events being removed from the set. Those with participants will be converted to standalone events, and those without registration will be deleted.

A repeating set will be created with the following dates.
➊ (table listing existing events to be removed)
➋ (table listing events to be created)

After

⚠️ There are participants registered for repeating events being removed from the set. Those with participants will be converted to standalone events, and those without registration will be deleted.
➊ (table listing existing events to be removed)

A repeating set will be created with the following dates.
➋ (table listing events to be created)

Technical Details

I suspect this is the least of concerns in this code, but at least this is something that is definitely wrong and can be fixed in a cinch.

@civibot
Copy link

civibot bot commented Jun 16, 2023

(Standard links)

@civibot civibot bot added the master label Jun 16, 2023
@aydun
Copy link
Contributor

aydun commented Jun 16, 2023

Obvious error - thanks for the fix @artfulrobot

@aydun aydun merged commit 26e9bf5 into civicrm:master Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants