Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlexMailer\Listener\OpenTracker: remove deprecated isLegacy check #26526

Conversation

semseysandor
Copy link
Contributor

Overview

Fix Todo: After v5.21 goes EOL, remove the $isLegacy check.

Before

Checking if Civi version is greater than 5.23.alpha.

After

Check removed.

@civibot
Copy link

civibot bot commented Jun 14, 2023

(Standard links)

@civibot civibot bot added the master label Jun 14, 2023
@semseysandor
Copy link
Contributor Author

A quick review of the test console output, I think failure is caused by this:

md5_file(/tmp/drush_tmp_1686748201_6489bc2952b3a/drupal-7.98.tar.gz):  [war  
  ning]                                                                        
  Failed to open stream: No such file or directory drush.inc:727               
  File drupal-7.98.tar.gz is corrupt (wrong md5 checksum).                 [e  
  rror]   

Guess it's not the unit-tests?

@totten
Copy link
Member

totten commented Jun 14, 2023

civibot, test this please

@totten
Copy link
Member

totten commented Jun 14, 2023

Looks pretty good to me. Let's see if another test-run clears that up.

@eileenmcnaughton eileenmcnaughton merged commit ffc0410 into civicrm:master Jun 14, 2023
@semseysandor semseysandor deleted the open-tracker-legacy-check branch June 14, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants