dev/core#4338 - Prevent people from sneakily adding fields to your extension's reserved custom groups by using the Move action #26518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issue was found matching the number given in the pull request title. Please check the issue number. |
|
(Standard links)
|
colemanw
reviewed
Jun 13, 2023
| @@ -91,7 +91,15 @@ public function preProcess() { | |||
| */ | |||
| public function buildQuickForm() { | |||
|
|
|||
| $customGroup = CRM_Core_PseudoConstant::get('CRM_Core_DAO_CustomField', 'custom_group_id'); | |||
| $customGroup = []; | |||
| $groups = \Civi\Api4\CustomGroup::get() | |||
There was a problem hiding this comment.
We get bitten by forgetting to pass FALSE here... but I think in this context checking permissions is ok. Anyone who doesn't have permission to see custom groups has no business using this form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
https://lab.civicrm.org/dev/core/-/issues/4338
Before
After
Reserved groups not listed as an option in the dropdown.
Technical Details
The UI currently goes out of its way to prevent you even seeing that reserved groups exist on the custom group admin screen, and bouncing if you try to hack an edit link to a field. It should also prevent moving a field into the group.
The call to Pseudoconstant::get is discouraged in its docblock so since I was changing it anyway I replaced with api.
Comments