Reduce PHP warnings with paymentBlock #26505
Conversation
|
(Standard links)
|
| {capture assign='contributionPageID'}id={$contributionPageID}&{/capture} | ||
| {else} | ||
| {capture assign='pageID'}{/capture} | ||
| {capture assign='contributionPageID'}{/capture} |
There was a problem hiding this comment.
I'm a bit confused by this. Is it defining an empty variable to avoid notices?
There was a problem hiding this comment.
Yes, that's what it's doing. Seems like a weird way to go about this, but I'm not aiming to change that.
There was a problem hiding this comment.
Can you explain why this variable needs to be renamed?
There was a problem hiding this comment.
So, there are five variables used to build the dataUrl at 106. Each is defined here in the same way in an if-else block that assigns the value if it exists or nothing if not.
This one was wrong, because it used PageID instead of ContributionPageID in the else. PageID is not a variable used anywhere else here. I'm just correcting that error, so that if there is no ContributionPageID, the variable is still assigned.
|
Ok I agree this is a step forward. |
Overview
This reduces the PHP warnings on the backend when using paymentBlock.tpl.
First, by not adding any of the unnecessary JS to show/hide the payment block when on the backend.
Second, by not checking $contributionPageID and $custom_pre_id when on the backend.
Still more to do here in the future, but this is a step forwards.