Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e-notices on New Participant form, strict smarty #26487

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fix e-notices on New Participant form, strict smarty

Before

image

After

image

Technical Details

The entityID is assigned fairly frequently when this template is used by groupID is rarely assigned - so this addresses when including the file - and could probably be done in other places that include it

image

Comments

@civibot
Copy link

civibot bot commented Jun 9, 2023

(Standard links)

@civibot civibot bot added the master label Jun 9, 2023
@larssandergreen
Copy link
Contributor

Looks good, resolves the warnings. I imagine there is a reason for groupID='' instead of NULL?

@colemanw colemanw merged commit 320126b into civicrm:master Jun 9, 2023
@colemanw colemanw deleted the notice_part branch June 9, 2023 22:30
@eileenmcnaughton
Copy link
Contributor Author

@larssandergreen no not really - I thought about NULL & then thought 'maybe that is wrong' - but I'm not sure it was

@larssandergreen
Copy link
Contributor

@eileenmcnaughton You were right, NULL is wrong. Not sure on the details, but when I tried it, the warning was gone, but I got another warning for a variable that was within the if. Using '' instead works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants