SearchKit - Fix saving created/modified fields

[colemanw]

Overview

Fixes saving created/modified info when updating a savedSearch in SearchKit.

Before

1. Edit a search
2. The name of the last-modified user ought to be set to you, but instead it is unchanged.

After

Fixed.

Technical Details

Don't select created/modified id or date fields when loading SavedSearch so they don't get sent back as values. The BAO will then be free to auto-fill them.

Comments

I think there are some larger issues here where we need to teach APIv4 not to mess with fields set to <readonly> in the schema. But this PR is the most minimal change and can be safely merged regardless of what other stuff we end up doing.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[monishdeb]

I have tested in the test build http://core-26484-3ypkt.test-1.civicrm.org:8001 (admin / xY5kZ8DLN9nZ) and it looks good to me. The modified date is now updated correctly:

In this demo I tested with another user who modified one of the existing searchkit criteria and the modified date was rightfully updated.

[colemanw]

Thanks for merging @monishdeb !