Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CiviEventDispatcher::dispatch() - add deprecation warning for deprecated event class #26338

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

demeritcowboy
Copy link
Contributor

Overview

See #26276 and #26212

Before

No warning - extension will fail hard in drupal 10 or when civi ups the minimum symfony version.

After

Warning

Technical Details

See above linked PRs.

I've linked to the dev docs where we could add some more discussion so have tried to keep the message here straightforward and not require too much thinking for those who don't need it. See also https://lab.civicrm.org/documentation/docs/dev/-/merge_requests/1078 since the dev docs reference the outdated class.

Comments

I tested what happens if run when the class doesn't exist. It doesn't seem to mind.

@totten @dontub

@civibot
Copy link

civibot bot commented May 24, 2023

(Standard links)

@civibot civibot bot added the master label May 24, 2023
@demeritcowboy demeritcowboy force-pushed the symfony-deprec branch 4 times, most recently from b5e6a77 to fa10112 Compare May 24, 2023 22:53
@totten
Copy link
Member

totten commented Jun 7, 2023

Since just start 5.64.alpha, I think it's good time to merge this.

@demeritcowboy - I did some r-run on D7 (make a fake extension; have it fire some event-classes), and it seemed to work well. Warning appeared in both web UI and log.

@totten totten merged commit f3b891f into civicrm:master Jun 7, 2023
@demeritcowboy demeritcowboy deleted the symfony-deprec branch June 9, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants