CiviGrant - Fix upgrade to work on multiple domains #26118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ensures CiviGrant component is completely removed by the upgrader.
Before
In certain conditions, such as multi-domain, CiviGrant setting was not completely removed by the upgrader step. This is pretty harmless except it was causing problems with #26036.
After
Component enable/disable functions cleaned up. Upgrader fixed.
Technical Details
The
CRM_Core_BAO_ConfigSetting::disableComponent()
wasn't working as expected by the upgrader because