Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate unused 'validContact' function #26075

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Deprecate unused 'validContact' function #26075

merged 1 commit into from
Apr 19, 2023

Conversation

colemanw
Copy link
Member

Overview

Deprecate unused redundant function.

Before

Unused validContact function redundant with positiveInteger.

After

Deprecated

@civibot
Copy link

civibot bot commented Apr 18, 2023

(Standard links)

@civibot civibot bot added the master label Apr 18, 2023
@demeritcowboy
Copy link
Contributor

demeritcowboy commented Apr 19, 2023 •
edited
Loading

This seems ok. One of the tricky parts to seeing if this is used anywhere is that this func gets registered as a quickform validation rule, so there might be something like $form->addRule(blah... ,'validContact',..., but I don't see anything like that in universe.

@demeritcowboy demeritcowboy merged commit 9ca1080 into civicrm:master Apr 19, 2023
@colemanw colemanw deleted the deprecateValidContact branch April 19, 2023 13:12
@colemanw
Copy link
Member Author

Thanks @demeritcowboy I agree it doesn't appear to be used, but we can leave it deprecated for a while just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @demeritcowboy