[SearchKit] Do not crash on entities without fields #26045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The SearchKit admin interface crashes when there are entities without fields (e.g. custom API entities not derived from DAOs).
Before
A custom API entity without any fields causes the SearchKit admin interface to crash with
TypeError: array_reverse(): Argument #1 ($array) must be of type array, null given in array_reverse()
.After
Entites without fields just don't have fields in SearchKit, no crashing.
Technical Details
There's an assumption that empty attributes for entities should not be part of the schema at all in
\Civi\Search\Admin::getSchema()
, but SearchKit relies on the attributefields
being there in\Civi\Search\Admin::addImplicitFKFields()
.