Clarify return on BAO_Activity::create

[eileenmcnaughton]

Overview

Clarify return on BAO_Activity::create

Before

The declared return types from BAO_Activity::create are CRM_Activity_BAO_Activity|null|object but it only ever returns a BAO_Activity

After

Declared return type corrected. Legacy handling for error object removed

Technical Details

The save function doesn't return an error object - although I believe it did before we made exceptions the consistent error handling method - so I removed that handling

Comments

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).