Fix for issue when optional contact_id is blank importing contributions #25897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
import_contact_id
branch
4 times, most recently
from
6247e6b to
bb0ddcb
Compare
eileenmcnaughton
force-pushed
the
import_contact_id
branch
from
bb0ddcb to
c3176ab
Compare
|
I'm satisfied with the test coverage here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix for issue when optional contact_id is blank importing contributions
Before
Contribution import falls over if
contact_idis present as an optional field (ie some contacts have it & not others) due to an empty string rather than NULL be passed into a function with a type hintAfter
Fixed... with test
Technical Details
@mlutfy this is the same as the soft credit contact one - probably a bit less common to hit it.
Comments