Skip adding script when it won't have anything to run on #25882
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In the Tagset template, only load a script for form controls if those controls exist.
Before
Script was always added to the page.
After
Script is only inserted when necessary.
Comments
I'd also like to get rid of the whole empty table that's created when there's no tagset data:
templates/CRM/Case/Form/Activity.tpl:244
templates/CRM/Case/Form/Case.tpl:108
Probably using this model?
templates/CRM/Activity/Form/Activity.tpl:168
But that can be a separate PR