Php8.2 fixes in report addToDeveloperTab function
#25800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Hmm will I be able to read the style parser output once they have all finished? Cos I'm confused right now |
CRM/Report/Form.php
Outdated
| @@ -1534,8 +1537,8 @@ public function addToDeveloperTab($sql) { | |||
| foreach (['FROM', 'WHERE', 'GROUP BY', 'ORDER BY', 'LIMIT', ';'] as $term) { | |||
| $sql = str_replace($term, '<br><br>' . $term, ($sql ?? '')); | |||
| } | |||
| $this->sqlFormattedArray[] = $sql; | |||
| $this->assign('sql', implode(';<br><br><br><br>', $this->sqlFormattedArray)); | |||
| $sqlFormattedArray = $sql; | |||
There was a problem hiding this comment.
This doesn't look right. $sql is a string - it should be added to the array not replacing the array.
There was a problem hiding this comment.
@demeritcowboy yep - you are right - I wonder if that is what the tests are trying to tell me or not
eileenmcnaughton
force-pushed
the
82_sql
branch
from
609c295 to
47ef1ea
Compare
|
The test seems to start crashing around here. I don't know if it's related - it doesn't give a stacktrace. |
|
jenkins retest this please |
eileenmcnaughton
force-pushed
the
82_sql
branch
from
47ef1ea to
072f1e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Php8.2 fixes in report
addToDeveloperTabfunctionBefore
api_v3_ReportTemplateTest::testReportTemplateGetRowsAllReports with data set #25 ('case/demographics')
Failure in api call for report_template getrows: Creation of dynamic property CRM_Report_Form_Case_Demographics::$sqlFormattedArray is deprecated
After
local variable used
Technical Details
Minor NFC tidy ups
Comments