Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stricter typing in Apiv4 #25706

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Stricter typing in Apiv4 #25706

merged 1 commit into from
Mar 1, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Stricter typing in Apiv4

Before

A someone common error is for entity to be null - which is picked up by strict typing - but not until futher down the chain

After

Pick up invalid data earlier through strict typing

Technical Details

@colemanw

Comments

@civibot
Copy link

civibot bot commented Mar 1, 2023

(Standard links)

@civibot civibot bot added the master label Mar 1, 2023
@colemanw
Copy link
Member

colemanw commented Mar 1, 2023

Makes sense

@eileenmcnaughton eileenmcnaughton merged commit 716a8dc into civicrm:master Mar 1, 2023
@eileenmcnaughton eileenmcnaughton deleted the strict branch March 1, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw