civiimport - PEAR Exception handling - Mitigation of scenario where an import table has been deleted and the metadata is out of date

[eileenmcnaughton]

Overview

This fixes a situation where a fatal error on the main SearchKit screen which arises if the temp table for an import is deleted but the metadata cache for \Civi::cache('metadata')->get('api4.entities.info', []); still retains it.

This is most easily replicated by doing an import, deleting the temp table in the DB and then going to the search kit screen

Steps to reproduce:

• Enable civiimport
• Start an import. Upload a CSV. Press "Back" to submit a new upload.
• In another tab, open /civicrm/admin/search#/list?tab=packaged.

Before

With Civi Import enabled....

After

Technical Details

Although a try-catch- was added to SearchKitit is by-passed by thePEAR_Exception. I could catch the PEAR_Exception` in SearchKit but SearchKit 'shouldn't have to' so handling in the ImportProvider / converting the exceptions.

civicrm-core/ext/search_kit/Civi/Search/Admin.php

Lines 147 to 157 in 4d8aca0

	try {
	$getFields = civicrm_api4($entity['name'], 'getFields', [
	'select' => ['name', 'title', 'label', 'description', 'type', 'options', 'input_type', 'input_attrs', 'data_type', 'serialize', 'entity', 'fk_entity', 'readonly', 'operators', 'suffixes', 'nullable'],
	'where' => [['deprecated', '=', FALSE], ['name', 'NOT IN', ['api_key', 'hash']]],
	'orderBy' => ['label'],
	]);
	}
	catch (\CRM_Core_Exception $e) {
	\Civi::log()->warning('Entity could not be loaded', ['entity' => $entity['name']]);
	continue;
	}

Thoughts about exceptions in #25600

Comments

I've figured out the scenario where this was happening & will separately address - but I think we should handle this regardless as I think there will always be some chance of it arising

Not strictly a regression but the handling that did not have enough cover to catch the PEAR_Exception is in 5.59

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[eileenmcnaughton]

really - still running/

test this please

[totten]

Discussed on MM to figure out steps-to-reproduce. Updated description. Confirmed that the patch fixed. 👍