Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(REF) Remove test reference to property which no longer exists #25624

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

braders
Copy link
Contributor

@braders braders commented Feb 19, 2023

Overview

Remove test reference to property which no longer exists.

Before

The test code referenced $parser->_dedupeRuleGroupID = $ruleGroupId;, despite their being no other references to _dedupeRuleGroupID in the codebase; therefore this property is not doing anything.

Furthermore, this means _dedupeRuleGroupID was a dynamic property, deprecated in PHP 8.2.

After

Pointless line of code removed.

Technical Details

The commit 3592a5e4098c9d14b2577a0f6eee5c6c7d471501` removed the _dedupeRuleGroupID property from the CRM_Contact_Import_Parser_Contact class in June last year. Prior to that, setting the _dedupeRuleGroupID property in the test would have made sense.

@civibot
Copy link

civibot bot commented Feb 19, 2023

(Standard links)

@civibot civibot bot added the master label Feb 19, 2023
@seamuslee001 seamuslee001 merged commit ee2d5e8 into civicrm:master Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants