(REF) Remove test reference to property which no longer exists #25624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove test reference to property which no longer exists.
Before
The test code referenced
$parser->_dedupeRuleGroupID = $ruleGroupId;
, despite their being no other references to_dedupeRuleGroupID
in the codebase; therefore this property is not doing anything.Furthermore, this means
_dedupeRuleGroupID
was a dynamic property, deprecated in PHP 8.2.After
Pointless line of code removed.
Technical Details
The commit 3592a5e4098c9d14b2577a0f6eee5c6c7d471501` removed the
_dedupeRuleGroupID
property from theCRM_Contact_Import_Parser_Contact
class in June last year. Prior to that, setting the_dedupeRuleGroupID
property in the test would have made sense.