[REF][PHP8.2] Tidy up properties in CRM_Event_BAO_EventPermissionsTest

[braders]

Overview

Tidy up properties in CRM_Event_BAO_EventPermissionsTest.

Before

The CRM_Event_BAO_EventPermissionsTest test class used dynamic properties, which are deprecated in PHP 8.2.

After

The use of dynamic properties has been removed, and some of the property names have been improved to fit the current CiviCRM best-practices.

There were also a few instances of this line:

$this->_loggedInUser = CRM_Core_Session::singleton()->get('userID');

I couldn't see _loggedInUser used in the tests, or in any CiviUnitTestCase methods that this test is calling. Therefore these lines have been removed.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).