Afform: Fix broken syntax for saving reciprocal relationships #25620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
mattwire
force-pushed
the
afformrelationship
branch
from
1f9c830 to
8d97ee4
Compare
|
test this please (unrelated but might as well go for the green tick) |
mattwire
force-pushed
the
afformrelationship
branch
from
8d97ee4 to
412fac1
Compare
|
Thanks @mattwire for fixing our broken 💔 relationships. Just in time for valentine's day 😍 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The syntax for saving reciprocal relationships is wrong and API4 fails (with 500 internal server error) on form submission if you have a relationship of that type on the form.
Before
Form submission fails with 500 internal server error if you have reciprocal relationship on the form.
After
Form submission succeeds - relationship is saved!
Technical Details
After inserting a bunch of debug statements I narrowed down the issue to the
processRelationships()function and then the API4 syntax. Comparing with API4 explorer shows the code was wrong and did not have enough [[[[]]]]Comments
@colemanw