Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smarty notice fix #25544

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Smarty notice fix #25544

merged 1 commit into from
Feb 11, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fixes

image

@civibot
Copy link

civibot bot commented Feb 9, 2023

(Standard links)

@civibot civibot bot added the master label Feb 9, 2023
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton
Copy link
Contributor Author

Test Result (1 failure / +1)
E2E\Core\AssetBuilderTest.testInvalid

test this please

@totten totten merged commit d4db6a1 into civicrm:master Feb 11, 2023
@demeritcowboy
Copy link
Contributor

Upgrades are (sort of) failing now - there is no $form variable so this causes a fatal error on the success screen. In fact there is no such variable as $afterUpgradeMessage - it must be some old code - the message you're seeing is inside $message.

@demeritcowboy demeritcowboy mentioned this pull request Feb 11, 2023
Merged
@seamuslee001 seamuslee001 deleted the smarty_tpl branch February 11, 2023 05:04
@demeritcowboy
Copy link
Contributor

Fix is at #25554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @demeritcowboy @totten