Prevent PHP warnings when no WordPress user is found

[christianwach]

Overview

When no WordPress user is found, PHP warnings are issued:

Warning: Attempt to read property "data" on bool
Warning: Attempt to read property "ID" on bool

Additionally, the WP_User object has magic methods for retrieving the ID directly, so there is no need to look in the data property.

Before

PHP warnings are issued.

After

No PHP warnings are issued.

Comments

IMO too minor a fix to open an issue on Lab.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[kcristiano]

This looks good to me. Not sure why that test failed.

[totten]

Ah, looks pretty sensible.

https://developer.wordpress.org/reference/classes/wp_user/ says ->ID is very slightly newer... going back to WP v2.1.0. 🙃

Test failure is probably unrelated. Fired a manual supplement to be sure (https://test.civicrm.org/job/CiviCRM-Manual-Test/39/), and that passed.