simplify calculation of lifetime memberships in CRM_Price_BAO_PriceSet #25456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
CRM/Price/BAO/PriceSet.php
Outdated
| $form->assign('ispricelifetime', TRUE); | ||
| $contactId = $form->getVar('_membershipContactID'); | ||
| if ($contactId && $options) { | ||
| $checklifetime ?: self::checkCurrentMembership($options, $contactId); |
There was a problem hiding this comment.
does that work - I thought it would need to be
$checklifetime = $checklifetime ?: self::checkCurrentMembership($options, $contactId);
if it does work - does it work on all php versions
There was a problem hiding this comment.
No, you're right - at the end of the night I was looking at small ways to improve my code, meaning a) it was after I'd done testing, b) it was late. This was a mistake.
MegaphoneJon
force-pushed
the
lifetime-membership-fix-1
branch
from
8a1696c to
bd9e389
Compare
|
OK - this looks good - I'm not going to insist on a unit test as it is a vaildation function so a little lower priority |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Civi has long had many different functions for calculating lifetime memberships. Many are buggy.
I was hunting for one such bug when I found this. I don't think this gives incorrect results, but it is a) inefficient, b) gives uninitialized variable warnings.
Before
Uninitialized variables, unused static vars, making a separate query for every price option on the page.
After
Initialized variables, one query per price field on the page (my price fields have 15 options each). Shouldn't look for lifetime memberships if one is found in an earlier price field.
Comments
checkCurrentMembership()is called only from one place, exclusively to set the$ispricelifetimevariable, which is used exclusively to display a message in the template if the user has a lifetime membership (that matches the membership types on the page).static $_contact_membershipsisn't used anywhere, I checked.