(NFC) Speed up random tests by 55-60% #25439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: On local i3-12100, takes ~90s (avg over 2 runs) After: On local i3-12100, take ~40s (avg over 2 runs)
Before: On local i3-12100, takes ~64s (avg over two runs) After: On local i3-12100, take ~28s (avg over two runs)
Before: On local i3-12100, takes ~34s (avg over two runs) After: On local i3-12100, take ~14s (avg over two runs)
Before: On local i3-12100, takes ~34s (avg over two runs) After: On local i3-12100, take ~14s (avg over two runs)
Before: On local i3-12100, takes ~17s (avg over two runs) After: On local i3-12100, take ~8s (avg over two runs)
|
(Standard links)
|
Just breaking that out -- the CRM and api3 suites are the longest/slowest (circa 30min-70min, depending on the node/hardware/concurrent load). When suites are running in parallel, these tend to finish last - so optimizing these suites should have more impact on the total/perceived time (compared to optimizing other suites). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Slower
After
Faster
Technical Details
useTransaction()Comments
I noticed that the CRM suite is particularly slow, so I skimmed the recent results. While there are a few particularly expensive tests (>1min ea), they don't actually account for a huge percentage of the suite. The overhead is more diffuse - there's a huge number of tests, all with a chunk of overhead. This kind of thing reduces that overhead.