Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF][PHP8.2] Declare system property in tests #25401

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

braders
Copy link
Contributor

@braders braders commented Jan 21, 2023

Overview

Declare system property in tests.

Before

3 tests were declaring $this->system as a dynamic property, which is deprecated in PHP8.2

After

Propery is decalared on the affected classes, PHP 8.2 compatiable.

These are tests so there should hopefully be no backwards compatability impact.

@civibot
Copy link

civibot bot commented Jan 21, 2023

(Standard links)

@civibot civibot bot added the master label Jan 21, 2023
@totten
Copy link
Member

totten commented Jan 25, 2023

civibot, test this pleas

@totten
Copy link
Member

totten commented Jan 26, 2023

civibot, test this please

@totten totten merged commit e05d4e6 into civicrm:master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants