dev/core#4112 Privatise prevNextCache functions
#25392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
prev_next_divide
branch
from
b4919a0 to
689a576
Compare
The buildPrevNextCache function had handling for the extensionised legacy searches mixed in with the core searches - this gives each it's own function, with the custom logic in the one on the Custom Selectore & removed from the core one. In addition I determined that these functions were only called from within their own classes & made them private
eileenmcnaughton
force-pushed
the
prev_next_divide
branch
from
689a576 to
f6c304b
Compare
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Feb 6, 2023
I was working on fixing the ongoing log noise in the tested scenario - but the first PR civicrm#25392 is still pending so I decided just to put up the test with the sign posts so at least that part is done for the next time someone tries (I know that people have tried in the past)
eileenmcnaughton
changed the title
prevNextCache functionsprevNextCache functions
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Feb 6, 2023
I was working on fixing the ongoing log noise in the tested scenario - but the first PR civicrm#25392 is still pending so I decided just to put up the test with the sign posts so at least that part is done for the next time someone tries (I know that people have tried in the past)
|
Did some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buildPrevNextCache function had handling for the extensionised legacy searches mixed in with the core searches - this gives each it's own function, with the custom logic in the one on the Custom Selectore & removed from the core one. In addition I determined that these functions were only called from within their own classes & made them private
Overview
Before
buildPrevNextCachecalled from 2 places in core & no others in universe - another similarly named function only called from within it's own class on CampaignfillupPrevNextCacheonly called from within it's own classAfter
buildPrevNextCache&fillupPrevNextCachecopied to the extension, withfillupPrevNextCacherenamed to justfilland fixed up so the core copy does the core stuff & the extension version does the extension stuffTechnical Details
This gets us close the extension being fully out of core & to being able to stop enabling it - the main gaps now are export - which I already did some work on & was gonna revive that PR & smart groups
Comments