Queues - Ensure that queue timings work, even with bad tzdata

[totten]

Overview

The queue tests have been reporting different results on different hosts -- e.g. they pass on test-{1,2,3} and on my laptop, but they fail on the temporary worker nodes. The difference is that tzdata does not appear to be loaded on the temp node's copy of mysqld.

This updates the queuing queries so that the correctness of tzdata does not affect the outcome.

Before

We can see that tests/phpunit/api/v4/Entity/QueueTest.php has several failures in this environment.

Note:

After

After: It doesn't matter if mysqld has tzdata. The test passes.

Comments

I'm not sure if this reflects a substantive bug for typical runtimes. It might... or it might be that the test-suite requires more unusual situations.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Test fail seems to relate

TypeError: Civi\Cv\Util\ConsoleQueueRunner::formatTaskCallback(): Argument #1 ($task) must be of type CRM_Queue_Task, bool given, called in phar:///home/jenkins/bknix-dfl/bin/cv/vendor/composer/../../src/Util/ConsoleQueueRunner.php on line 76 in Civi\Cv\Util\ConsoleQueueRunner::formatTaskCallback() (line 109 of phar:///home/jenkins/bknix-dfl/bin/cv/vendor/composer/../../src/Util/ConsoleQueueRunner.php).

[totten]

Yeah, I haven't quite figured out why -- but I bisected the changes, and it has something to do with the update to SqlTrait::createItem().

[totten]

Fixed by telling executeQuery() skip multilingual rewrites. The serialized $task record was getting filtered, yielding an invalid record (which could not be unserialized). Ex:

1. You have an upgrade-task with a title. The title includes a table name.
   • Update the foozballs in civicrm_dashboard for whimsy
2. The upgrade-task is serialized. Part of this is the title with the table name.
   • s:52:"Update the foozballs in civicrm_dashboard for whimsy";
3. The entire INSERT query was filtered by Schema::rewriteQuery()
   • s:52:"Update the foozballs in civicrm_dashboard_en_US for whimsy"; (string is now 57 chars but described as 52 chars -- which is malformed/unloadable)

[eileenmcnaughton]

My general take is that the tests are passing & they are the most strict consumer of this code - but I have not actually merged at this stage in case @seamuslee001 wants to weigh in

[eileenmcnaughton]

I'm gonna merge this now - cos all these failing tests are making stuff hard - I'm sure @seamuslee001 can add post-merge comments if need be