[REF][PHP8.2] Fix PHP8.2 creation of dynamic properties in the elavon… #25353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests and Payment Processor class
|
(Standard links)
|
This was referenced Jan 15, 2023
|
This seems low risk - although I would probably vote that with code we are looking to deprecate we think about what NOT upgrading it to php 8.2 might look like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… tests and Payment Processor class
Overview
This fixes the creation of dynamic properties in class in the elavon extension
Before
Elavon tests fail in PHP8.2
After
Tests pass on php8.2
ping @eileenmcnaughton @demeritcowboy @braders