dev/core#1984 fix custom fields sometimes missing from profiles

[spalmstr]

Overview

We were finding that custom fields were missing from profiles from time to time. See Sometimes Custom fields missing on profile

Before

Profiles would be missing their custom fields even if the user had access to them.

After

Profiles are now available to users, even if a less privileged user was the first one to access the profile after a cache refresh.

Technical Details

The list of custom fields for a profile is held in a cache created when the profile is first accessed after the cache has expired. Before this change that cache was generic to all users,, so it only held the fields visible to the first user accessing the profile after the cache refresh. If that user did not have access to the fields, they were not in the cache and subsequent users couldn't see them. By adding the user ID to the cache key, it means that each user creates their own cache, so they can see the fields to which they have access.

Comments

Anything else you would like the reviewer to note
It is a very simple change, simply adding the user id to the cache key used to hold the custom field information.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@spalmstr there are a couple of style issues - https://test.civicrm.org/job/CiviCRM-Core-PR/53071/checkstyle/

Non blocking but I think $contactID rather than $id is a clearer variable name for the contact id of the logged in user

[eileenmcnaughton]

Thanks @spalmstr