-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(dev/core#2301) Profiles - Add Drupal 8+ specific check and extract to CRM_Utils_System #25315
Conversation
(Standard links)
|
Looks good to me do you agree @demeritcowboy ? |
Says it failed on an asset builder test? Seems unrelated |
yen that is a known failure at the moment |
Also seems to be general mysql fails on several PRs right now. I can review tomorrow. |
Thanks @herbdool. This works to make it more like drupal 7 and it's good cleanup to get rid of There are still several problems with the form, such as not validating properly because it uses title instead of name to find the profile, and so now instead of an error it silently says "updated successfully" even when it didn't, but we can treat separately. |
I can't update the lab ticket since something seems strange about labs at the moment. Will update later. |
@demeritcowboy yup, I noticed. At least it'll be easier to untangle the other problems after this too. And a bonus, this will now work in Backdrop as well. |
Fixes https://lab.civicrm.org/dev/core/-/issues/2301