Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#2301) Profiles - Add Drupal 8+ specific check and extract to CRM_Utils_System #25315

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

herbdool
Copy link
Contributor

@civibot
Copy link

civibot bot commented Jan 10, 2023

(Standard links)

@civibot civibot bot added the master label Jan 10, 2023
@seamuslee001
Copy link
Contributor

Looks good to me do you agree @demeritcowboy ?

@totten totten changed the title Core#2301 Add Drupal 8+ specific check and extract to CRM_Utils_Syste… (dev/core#2301) Profiles - Add Drupal 8+ specific check and extract to CRM_Utils_System Jan 11, 2023
@herbdool
Copy link
Contributor Author

Says it failed on an asset builder test? Seems unrelated

@seamuslee001
Copy link
Contributor

yen that is a known failure at the moment

@demeritcowboy
Copy link
Contributor

Also seems to be general mysql fails on several PRs right now.

I can review tomorrow.

@demeritcowboy
Copy link
Contributor

demeritcowboy commented Jan 11, 2023

Thanks @herbdool. This works to make it more like drupal 7 and it's good cleanup to get rid of == 'Drupal'.

There are still several problems with the form, such as not validating properly because it uses title instead of name to find the profile, and so now instead of an error it silently says "updated successfully" even when it didn't, but we can treat separately.

@demeritcowboy demeritcowboy merged commit d923ad0 into civicrm:master Jan 11, 2023
@demeritcowboy
Copy link
Contributor

I can't update the lab ticket since something seems strange about labs at the moment. Will update later.

@herbdool
Copy link
Contributor Author

@demeritcowboy yup, I noticed. At least it'll be easier to untangle the other problems after this too. And a bonus, this will now work in Backdrop as well.

@herbdool herbdool deleted the core-2301 branch January 12, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants