Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php 8.2 fix undefined property, move test to appropriate extension #25313

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Php 8.2 fix undefined property, move test to appropriate extension

Before

Test affected by an undefined property, test should be in the legacycustomsearch extension, but isn't

After

Test moved, undefined property fixed

Technical Details

The undefined property was a hack to access a protected property - I added a getter

I also added a default api version to ContactTestTrait - existing uses will have all had to define it so this won't cause any issues there

Comments

@civibot
Copy link

civibot bot commented Jan 10, 2023

(Standard links)

@civibot civibot bot added the master label Jan 10, 2023
@totten totten merged commit 1d09560 into civicrm:master Jan 11, 2023
@totten totten deleted the test_full branch January 11, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants