Php 8.2 fix undefined property, move test to appropriate extension #25313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Php 8.2 fix undefined property, move test to appropriate extension
Before
Test affected by an undefined property, test should be in the
legacycustomsearch
extension, but isn'tAfter
Test moved, undefined property fixed
Technical Details
The undefined property was a hack to access a protected property - I added a getter
I also added a default api version to
ContactTestTrait
- existing uses will have all had to define it so this won't cause any issues thereComments