Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Remove broken test #25279

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Conversation

demeritcowboy
Copy link
Contributor

Overview

This test is broken in a number of ways which I'm not interested in taking on fixing at this time:

  • It doesn't even run when the suite is run because the class name is different than the file. (This is a trick you can use to get all your tests to pass!) So it's not doing anything at the moment anyway.
  • It tries to look for a file tests/phpunit/CRM/Event/Import/Parser/data/participant_with_event_id.csv which does not exist so it fails even when it does run.
  • If you remove that item from the dataprovider it still fails so either the test is wrong or the actual import code is wrong. I dunno.

@civibot
Copy link

civibot bot commented Jan 4, 2023

(Standard links)

@civibot civibot bot added the master label Jan 4, 2023
@demeritcowboy
Copy link
Contributor Author

jenkins retest this please

@eileenmcnaughton
Copy link
Contributor

OK - fair call

@eileenmcnaughton eileenmcnaughton merged commit 2a067f5 into civicrm:master Jan 10, 2023
@demeritcowboy demeritcowboy deleted the party-test branch January 16, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants