Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows multiple Free Text fields to be added to form layout #25271

Merged

Conversation

eightiesguy
Copy link
Contributor

Overview

When building a conribution form, or altering the profile for a form, the Javascript rightly detects duplciate fields and prevents saving. Would like to make an exception for Free HTML fields (could be expanded to anything from the Formatting section if that section should expand)

Before

Work around is to save after each change. The form allows another Free HTML element to be added

After

Change alters the markDuplicates() method so that is_duplicate class is only applied when the ufFieldModel does not have the label 'Free HTML'. This will allow multiple Free HTML fields for formatting forms

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

@civicrm-builder
Copy link

Can one of the admins verify this patch?

@civibot
Copy link

civibot bot commented Jan 3, 2023

(Standard links)

@civibot civibot bot added the master label Jan 3, 2023
@eileenmcnaughton
Copy link
Contributor

add to whitelist

@demeritcowboy demeritcowboy added the merge ready PR will be merged after a few days if there are no objections label Jun 13, 2023
@demeritcowboy
Copy link
Contributor

jenkins ok to test

@eileenmcnaughton
Copy link
Contributor

I see your point @demeritcowboy regarding 'doesn't break anything so let's not let the limitations be blocking' - I would prefer the things you pointed out be moved to code comments though - ideally I think this would apply to all formatting fields (as mentioned above) but I haven't dug in to see how hard it would be to make that change

@eileenmcnaughton
Copy link
Contributor

@eightiesguy if you do have a chance to come back to this & up the code comments to save the person who says 'why doesn't think work on my French site' that would be good.

@demeritcowboy demeritcowboy added merge on pass and removed merge ready PR will be merged after a few days if there are no objections labels Jun 21, 2023
@demeritcowboy demeritcowboy merged commit a363d4e into civicrm:master Jun 21, 2023
@demeritcowboy
Copy link
Contributor

@eightiesguy Can you do another PR to add yourself to https://github.com/civicrm/civicrm-core/blob/master/contributor-key.yml for release notes credit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants