Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconditionally assign registerClosed on event info page #25251

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Unconditionally assign registerClosed on event info page

Before

image

After

First notice is gone

Technical Details

I changed the logic slightly in that it used to only show registerClosed ie
image

if the user had register event permission. This felt a bit overloaded & confusing to me & there didn't seem to be any harm in showing the text even if they couldn't register

Comments

@civibot
Copy link

civibot bot commented Jan 1, 2023

(Standard links)

@civibot civibot bot added the master label Jan 1, 2023
@eileenmcnaughton
Copy link
Contributor Author

test this please

1 similar comment
@yashodha
Copy link
Contributor

yashodha commented Jan 2, 2023

test this please

@yashodha
Copy link
Contributor

yashodha commented Jan 5, 2023

@eileenmcnaughton merging this PR.

@yashodha yashodha merged commit 3a1ed2d into civicrm:master Jan 5, 2023
@eileenmcnaughton eileenmcnaughton deleted the event_info branch January 5, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants