Standardise method of getting entity in imports #25173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
force-pushed
the
no_const
branch
from
c919d09 to
710eb58
Compare
|
Thanks @seamuslee001 @demeritcowboy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Standardise method of getting entity in imports
Before
Most places that check the entity for imports call
getBaseEntity, one checks the CONSTAfter
ALL places that check the entity for imports call `getBaseEntity
Technical Details
The consts can go - I am just conscious it would make #25171 stale / be hard to co-ordinate with changes to that PR so they can be removed in that PR or after it is merged
Comments