Default to supporting partial locales #25063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
local
branch
from
c98e1f8 to
4924aa4
Compare
|
@totten ths is passing - the test fails were only where we were specifically testing the use of the legacy separator settings - which are ignored with the setting - so I disabled for those tests |
|
@totten shouldn't we just merge this now it passes? |
|
test this please |
|
@totten you have agreed a few times this should be merged - but it is still unmerged... |
eileenmcnaughton
force-pushed
the
local
branch
from
4924aa4 to
ee051a3
Compare
|
@totten I think we agreed to merge this after the previous rc was cut... |
|
This seems fine to me and I do recall that I think this was agreed to some point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Default to supporting partial locales
Before
When introducing the
partial_localesetting we felt that 'ON' was the better default - but had enough test battles to fight that we left 'off' for startersAfter
Switches the default to ON
Technical Details
Comments
@totten not sure what the challenges were anymore but I guess we will see....