Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF][PHP8.1] Fix Extension Manager Module test failures on php8.1 du… #24733

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

seamuslee001
Copy link
Contributor

…e to passing in null to dirname

Overview

This fixes a couple of test errors on php8.1

Before

Following test errors on php8.1

1) CRM_Extension_Manager_ModuleTest::testInstall_DirtyRemove_Disable_Uninstall
dirname(): Passing null to parameter #1 ($path) of type string is deprecated

/home/seamus/buildkit/build/dtest/web/sites/all/modules/civicrm/Civi/Api4/Service/LegacySpecScanner.php:56

2) CRM_Extension_Manager_ModuleTest::testInstall_DirtyRemove_Disable_Restore
dirname(): Passing null to parameter #1 ($path) of type string is deprecated

/home/seamus/buildkit/build/dtest/web/sites/all/modules/civicrm/Civi/Api4/Service/LegacySpecScanner.php:56

After

No Test errors in php8.1 from these tests

ping @eileenmcnaughton @demeritcowboy @totten

@civibot
Copy link

civibot bot commented Oct 13, 2022

(Standard links)

@civibot civibot bot added the 5.55 label Oct 13, 2022
@demeritcowboy demeritcowboy merged commit 34737ec into civicrm:5.55 Oct 13, 2022
@eileenmcnaughton eileenmcnaughton deleted the fix_php81_module_tests branch October 20, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants