dev/core#3825 - CiviReport - number of rows to show parameter not working

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/3825

Before

1. Change the number of rows to show in the pager.
2. It doesn't change the number of rows that get shown.

After

Ok

Technical Details

I don't know when this broke or why there are two similar named params that seem to do the same thing. The problem is at least as old as 5.44.

Comments

There are some positive reviews in the lab ticket.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

This seems a bit weird as grepping it doesn't find the hits I thought it might - but I looked at the ticket & I think enough brain energy has gone into it & people agree it works so merging - thanks for fixing @demeritcowboy

[demeritcowboy]

Thanks.
Yeah you'd have to grep PAGE_ROWCOUNT too.