Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate civicrm_generated after #22686 and codegen params to in_array are backwards #24578

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

demeritcowboy
Copy link
Contributor

Overview

All activities are solo activities.

Before

Everyone does everything alone

After

Most activities are done with friends

Technical Details

backwards params

Comments

An alternative is use a different method since it's come up before there's some weirdness sometimes with in_array, but this PR should be a straightforward review.

@civibot
Copy link

civibot bot commented Sep 20, 2022

(Standard links)

@civibot civibot bot added the master label Sep 20, 2022
@totten
Copy link
Member

totten commented Sep 20, 2022

So if there was some issue where the test-processes depended on the previous/poorly-chosen activity examples -- then that would show up in the test-run for the companion PR, right (#24577)?

@demeritcowboy
Copy link
Contributor Author

Not yet since I didn't realize it was backwards until after I made that regen. I should reregen it with this patch applied.

@demeritcowboy
Copy link
Contributor Author

Ok so now any test weirdness should show up on this PR.

@demeritcowboy demeritcowboy changed the title Codegen params to in_array are backwards Regenerate civicrm_generated after #22686 and codegen params to in_array are backwards Sep 21, 2022
@seamuslee001
Copy link
Contributor

well tests pass

@seamuslee001 seamuslee001 merged commit 1328c3f into civicrm:master Sep 21, 2022
@demeritcowboy demeritcowboy deleted the inarray-backwards branch September 21, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants