dev/drupal#174 - Don't use internal CMS identifier as a human label - Option 1 #24561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
jenkins retest this please |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
https://lab.civicrm.org/dev/drupal/-/issues/174
Before
Mostly that it says Drupal8 when it's Drupal 9. The two screens are
civicrm/admin/synchUser?reset=1andcivicrm/contact/search/advanced?reset=1Also for standalone cms saying "standalone" isn't going to make sense.
After
This is option 1. It just removes all the extra wording which I'm not sure really adds anything. If someone needs clarification then maybe a link to more complete docs explaining the difference between users and contacts and what CMS means would be more useful.
Technical Details
CIVICRM_UF is an internal name not a human label.
Comments