Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv4 - Add Contact::mergeDuplicates action #24542

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

colemanw
Copy link
Member

Overview

Adds a mergeDuplicates APIv4 action, for parity with APIv3.

@civibot
Copy link

civibot bot commented Sep 16, 2022

(Standard links)

@civibot civibot bot added the master label Sep 16, 2022
@tschuettler
Copy link
Contributor

(CiviCRM Review Template DEL-1.2)

  • General standards
    • Explain (r-explain)
      • PASS : The goal/problem/solution have been adequately explained with a link (JIRA, Github, Gitlab, StackExchange).
    • User impact (r-user)
      • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.
    • Documentation (r-doc)
      • PASS: The changes do not require documentation.
      • COMMENTS: I believe new actions are not added to the docs in general.
    • Run it (r-run)
      • PASS: Checked out PR locally and performed a merge with APIv3 and APIv4 via API explorer and CLI
      • COMMENTS: The test site was not online anymore. I thought those lasted a few days?
  • Developer standards
    • Technical impact (r-tech)
      • PASS: The change preserves compatibility with existing callers/code/downstream.
    • Code quality (r-code)
      • PASS: The functionality, purpose, and style of the code seems clear+sensible.
    • Maintainability (r-maint)
      • PASS: The change sufficiently improves test coverage, or the change is trivial enough that it does not require tests.
    • Test results (r-test)
      • PASS: The test results are all-clear.
      • COMMENTS: I guess the test could have its own test class, but at least it is closely related to dupliates anyway.

@colemanw
Copy link
Member Author

Thanks for the review @tschuettler

@colemanw colemanw merged commit c00354b into civicrm:master Sep 19, 2022
@colemanw colemanw deleted the getDuplicates branch September 19, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants