Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression causing custom groups to reset to 'Contact' when updated #24220

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Fix regression causing custom groups to reset to 'Contact' when updated #24220

merged 1 commit into from
Aug 10, 2022

Conversation

colemanw
Copy link
Member

Overview

Fixes regression reported in dev/core#3794

@civibot
Copy link

civibot bot commented Aug 10, 2022

(Standard links)

@civibot civibot bot added the 5.53 label Aug 10, 2022
@colemanw colemanw mentioned this pull request Aug 10, 2022
Merged
@demeritcowboy
Copy link
Contributor

Fatal error: Cannot declare class api\v4\Custom\CustomGroupACLTest, because the name is already in use in /home/jenkins/bknix-dfl/build/core-24220-6xb3l/web/sites/all/modules/civicrm/tests/phpunit/api/v4/Custom/CustomGroupTest.php on line 27

I know there's no such thing as too many tests, but that'll teach you to add tests (grin).

I think just the class name needs to match the filename.

@colemanw
Copy link
Member Author

Thanks @demeritcowboy I didn't see that!

@seamuslee001
Copy link
Contributor

looks right to me

@seamuslee001 seamuslee001 merged commit d8a0db1 into civicrm:5.53 Aug 10, 2022
@seamuslee001 seamuslee001 deleted the customGroupFix branch August 10, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.53 has-test sig:regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colemanw @demeritcowboy @seamuslee001