[REF] Convert Elavon Payment Processor to use Guzzle and ensure that … #24131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
monishdeb
reviewed
Aug 3, 2022
| CURLOPT_SSL_VERIFYHOST => Civi::settings()->get('verifySSL') ? 2 : 0, | ||
| CURLOPT_SSL_VERIFYPEER => Civi::settings()->get('verifySSL'), | ||
| ], | ||
| ])->getBody(); |
There was a problem hiding this comment.
@seamuslee001 is it required to set the CURLOPT_FOLLOWLOCATION if as per L160 above?
There was a problem hiding this comment.
ok have updated to it @monishdeb
|
I don't suppose we can move it into an extension while we are touching it.... Are you able to test it with any test creds? Do we know if it even works? If it were an extension we could not support it for php 8.... |
|
@eileenmcnaughton I would rather not, I only put this up because I had to do this for a client today to fix their processing |
seamuslee001
force-pushed
the
elavon_guzzle
branch
from
ab22276 to
9a59bfb
Compare
…we are using POST requests not GET requests to Elavon end point Include CURLOPT_FOLLOWLOCATION param as before
seamuslee001
force-pushed
the
elavon_guzzle
branch
from
9a59bfb to
1989568
Compare
|
Merging this based on discussion with @seamuslee001 - key points
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…we are using POST requests not GET requests to Elavon end point
Overview
This updates the Elavon Payment Processor to use Guzzle and also use POST requests rather than Get
Before
Curl used and GET requests used
After
Guzzle used and POST requests used
ping @eileenmcnaughton @monishdeb @JoeMurray