Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv4 - Improve pseudoconstant support in getFields #24099

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

colemanw
Copy link
Member

Overview

Makes APIv4 smarter about automatically loading option lists for getFields

Before

A custom getFields function always had to deal with loading its own options.

After

This allows APIv4 getFields arrays to specify a pseudoconstant key which is automatically transformed into an array of options in the right format.

@civibot
Copy link

civibot bot commented Jul 31, 2022

(Standard links)

colemanw added 2 commits July 31, 2022 10:18
This allows APIv4 getFields arrays to specify a pseudoconstant key which is
automatically transformed into an array of options in the right format.
@colemanw
Copy link
Member Author

colemanw commented Aug 1, 2022

retest this please

@seamuslee001
Copy link
Contributor

this seems fine and should be well covered by unit tests

@eileenmcnaughton eileenmcnaughton merged commit 7d67931 into civicrm:master Aug 1, 2022
@eileenmcnaughton eileenmcnaughton deleted the api4options branch August 1, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants