Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix regex
Before
$argv[2] has "C:/path/to/git" prepended to it. Resulting patched file is an empty file.
After
Better
Technical Details
I dunno I guess in this context as an argument to a script it does argument expansion and preprocesses the
/
and thinks it's a file path and so converts it to an absolute file path? It might even be doing that on unix but happens to work out because the absolute path would be the same?Comments
@seamuslee001
Since this is a vendor package, should it be one of those patches that only lives in cyberspace instead?