Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Resolve phpunit warning about using assertContains on strings #24091

Merged
merged 1 commit into from
Jul 30, 2022

Conversation

seamuslee001
Copy link
Contributor

Overview

This resolves the following warning in phpunit runs

Warning Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.

Before

Warning is shown in phpunit runs

After

No warning

ping @eileenmcnaughton @colemanw @totten @demeritcowboy

@civibot
Copy link

civibot bot commented Jul 29, 2022

(Standard links)

@totten
Copy link
Member

totten commented Jul 29, 2022

+1. If the test passes, it's good.

@seamuslee001 seamuslee001 merged commit 2a6cdef into civicrm:master Jul 30, 2022
@seamuslee001 seamuslee001 deleted the phpunit_warning_fix branch July 30, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants