Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log a bit more deprecation info #24064

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Log a bit more deprecation info

Before

People (notably @aydun) commented that they can't track down where deprecation warnings are coming from when they see them in the ConfigAndLog

After

Hopefully this will add enough more to help find them without adding too much more

Technical Details

I realise we'd probably need to do similar to deprecationWarning - but just trying to see if we can do a small improvement

Comments

@civibot
Copy link

civibot bot commented Jul 27, 2022

(Standard links)

@civibot civibot bot added the master label Jul 27, 2022
@totten
Copy link
Member

totten commented Jul 27, 2022

So instead of showing one frame of the callstack ($dbt[1]), it shows 4 frames ($backtrace[0] to $backtrace[3])?

Sounds like a good idea.

CRM/Core/Error.php Outdated Show resolved Hide resolved
CRM/Core/Error.php Outdated Show resolved Hide resolved
eileenmcnaughton and others added 2 commits July 28, 2022 09:55
Co-authored-by: demeritcowboy <[email protected]>
Co-authored-by: demeritcowboy <[email protected]>
@demeritcowboy demeritcowboy merged commit 3623095 into civicrm:master Jul 28, 2022
@eileenmcnaughton eileenmcnaughton deleted the dep_err branch July 28, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants