Convert the type on the UserJob entity to be a string

[eileenmcnaughton]

Overview

Currently we are storing a numeric ID - however if we
permit non-core classes to register types we find numeric ids
quickly become hard to manage as uninstalling an extension could
change the id. This switches to using a string type

Before

civicrm_user_job uses type_id to track the job 'type' - but this can't be extended because an integer varies

After

civicrm_user_job now users job_type - a var char

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

Scope looks fairly sensible. I'll give it an r-run.

[totten]

r-run: DB Upgrade: I did some imports on 5.51.beta1, ran the upgrade to 5.51.beta2 (patch added), and inspected civicrm_user_job. The resulting schema matched, and the job_type's appeared to correlate to the previous type_ids. 👍

r-run: Import UI: I ran "Import Contacts", "Import Activities", and "Import Custom Data" (mostly using testdata, though I twiddled the activities.csv to set source_contact_id). The results appeared to be the same, but I think this is a new warning on the "Import Contacts" and "Import Activities":

Seems like a relevant warning?

[eileenmcnaughton]

Ah - that needs to be changed to job_type:label

[eileenmcnaughton]

@totten if it is just that e-notice are you OK to merge this & then I will do a follow up for it? It's a bit easier for me that way

[totten]

Well, I hadn't dug into see if the warning was meaningful. So I took a look now - and, in fact, page-title was wrong when using "Import Activities". Added a commit to fix.

[eileenmcnaughton]

lol yep - I knew that was it - I just didn't want to play the rebase game :-)

[totten]

Grepped around for other references to type_id. There are some comments that can be updated like:

* Get the name of the type to be stored in civicrm_user_job.type_id.

But that has no functional impact. That can be follow-up.

Aside for the record - as eileen noted elsewhere, this field is pretty new and only becomes meaningful with 5.51. So we don't expect that contrib has any r-tech reliance on this (yet). And it's a lot easier to adjust if we can get this into 5.51 before there is more meaningful downstream reliance.

Merge on pass.

[totten]

AFAICS, #23893 doesn't have any changes affecting Summary.php or FiveFiftyOne.php, so 🤞 you won't have to play the rebase game 🧺 🏀 ⛹️ .

[eileenmcnaughton]

@totten I would have had to to update this PR without overwriting your patch