returns weight 0 when weight column name is empty #23874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
Jun 23, 2022
|
@AlainBenbassat thanks for this! I think since it solves an existing bug this should be against the |
colemanw
force-pushed
the
empty-weight-column-during-upgrade
branch
from
1ff77a4 to
22082f9
Compare
colemanw
added
the
merge ready
|
I haven't ever encountered this bug myself during an upgrade, but this change is so safe, I think "why not?" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
During upgrades, some columns may not exist yet, causing CRM_Utils_Weight::getMax() to occasionally fail.
Before
Sometimes $weightField is empty which triggers a DB Error.
After
When $weightField is empty, a weight of zero is returned by CRM_Utils_Weight::getMax() and a warning is logged.