dev/core#3502 - CiviEventDispatcher - Softer errors for not-ready. More comments. #23785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
v5.50 is more likely to raise complaints about hooks that fire during bootstrap (as in the case of https://lab.civicrm.org/dev/core/-/issues/3502). This patch tries to turn-down the volume on such errors.
(This is the 5.51-rc variant of the patch. Stable patch is #23739.)
Before
After
trigger_error(...E_USER_WARNING)
)error_log()
) with backtrace.Comments
Two use-cases:
The easiest way to trigger an error is to hack
boot()
function, eg\CRM_Utils_Hook::singleton()->commonBuildModuleList('civicrm_boot'); +\CRM_Utils_Hook::entityTypes($x); $bootServices['dispatcher.boot']->setDispatchPolicy($mainDispatchPolicy);
I also managed to [reproduce the same error as @francescbassas](https://lab.civicrm.org/dev/core/-/issues/3502#note_75272. Activating
rules
wasn't enough -- I needed also needed a rule to specifically react to logs.